Add logger package for shared logging across ToolHive projects#13
Closed
niveshdandyan wants to merge 1 commit into
Closed
Add logger package for shared logging across ToolHive projects#13niveshdandyan wants to merge 1 commit into
niveshdandyan wants to merge 1 commit into
Conversation
This adds a structured logging package that can be used by both ToolHive Runtime and Registry projects. The logger provides: - Multiple log levels (Debug, Info, Warn, Error, Panic, Fatal) - Support for both structured (JSON) and unstructured (human-readable) output - Integration with logr.Logger for Kubernetes controller compatibility - Configurable debug mode via DebugProvider interface - Environment-based configuration via UNSTRUCTURED_LOGS env var The DebugProvider interface allows projects to plug in their own debug flag implementation (e.g., viper configuration). Related to stacklok/toolhive#3614 Co-Authored-By: Claude (claude-opus-4-5) <noreply@anthropic.com>
Member
|
Thanks for the PR @niveshdandyan. In the future, please comment on the issue so we can assign it to you before creating pull requests. This helps us coordinate contributions and avoid work duplication. Please check the contribution process here https://github.com/stacklok/toolhive/blob/main/CONTRIBUTING.md#claiming-an-issue |
Author
|
Thank you for the feedback @eleftherias! I apologize for not following the contribution process properly. I will make sure to comment on issues first to get them assigned before creating PRs in the future. I've noted the contribution guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shared logger package to toolhive-core for use by ToolHive Runtime, Registry, and other ToolHive ecosystem projects.
Related to stacklok/toolhive#3614
Changes
loggerpackage with structured logging capabilitieslogr.Loggerfor Kubernetes controller compatibilityDebugProviderinterfaceUNSTRUCTURED_LOGSenv varFeatures
The logger package provides:
NewLogr()for controller-runtime compatibilityDebugProviderinterface for configurable debug modeInitializeWithOptions()for test isolationAPI
Testing
go build ./...succeedsgo test ./...passesAI Transparency
This PR was created with the assistance of AI (Claude by Anthropic) for code generation and review.